Add a default span name #1770
Merged
Add a default span name #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
basepi force-pushed the default_span_name branch from e5c871e to d6551c9 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
We list
nameas a required argument in ourcapture_spandocs. However, if a span name is not provided, we silently set it toNone, and it gets dropped by the APM Server (as it's a required field).I didn't think this was acceptable behavior, so I copied what the Node agent does, and set the default to
"unnamed"so we don't silently drop spans.This also matches my spec change here: elastic/apm#772