[GRPC] Handle non-existent transaction in server interceptor #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added agent-python community 
beniwohli approved these changes Feb 28, 2023
There was a problem hiding this comment.
Hi @ckoehn
Good catch, the fix looks good. Testing this is indeed somewhat tricky, as our setup with a GRPC server in a subprocess is a bit convoluted. I added a test that does the trick, albeit a bit unsatisfactory. It fails without your patch, but will also pass if a transaction isn't recorded by our fake APM Server for other reasons. But I think it's acceptable for now.
| huh. not sure why this was auto-merged before the tests completed :/ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This change handles the case when APM is not recording/disabled and
client.begin_transaction()just returnsNone. I wasn't able to figure out how to add a test for this. Do you have an advice/hint?Related issues