Set status check to success in case it's an only-docs PR #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added agent-python community 
reakaleek changed the title 
v1v reviewed Feb 13, 2023
v1v reviewed Feb 13, 2023
.github/workflows/test-docs.yml Outdated
Comment on lines 4 to 8
| name: test | ||
| | ||
| on: | ||
| pull_request: | ||
| paths-ignore: # This expression needs to match the paths ignored on test.yml. |
There was a problem hiding this comment.
What do you think adding a comment in the file .github/workflows/test.yml saying that it's name should match the name in .github/workflows/test-docs.yml otherwise the workaround won't work?
beniwohli approved these changes Feb 13, 2023
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Feb 16, 2023
* Set status check to success in case it's a only-docs PR * Set permissions * fix path patterns * Add comments
basepi added a commit that referenced this pull request Feb 16, 2023
* handle case when no span is created in GRPC client interceptor closes #1739 * Migrate Jenkinsfile 2 GH Actions Workflow (#1731) * Migrate Jenkinsfile to GH Actions * Generic naming * Upload junit test and coverage reports on success or on failure * Better naming * Remove cron from packages workflow * Rename all occurences of WEBFRAMEWORK to FRAMEWORK * Add a warning about BaseHTTPMiddleware to Starlette docs (#1735) * Add a warning about BaseHTTPMiddleware to Starlette docs Also switch to using get_client() and make the docs simpler for environment variable configuration. * CHANGELOG * Change `server_url` default to avoid ipv6 ambiguity (#1744) * Change `server_url` default to avoid ipv6 ambiguity * Fix failing test and another minor doc fix * Add service.agent.activation_method to metadata (#1743) * Add activation_method to metadata * Add test * Move activation_method default above start_threads * CHANGELOG * Fix nightly scheduled test (#1747) * Split matrix items into chunks to bypass the 256 limit of matrix items in github actions * cleanup * Add comments * Add update-specs updatcli workflow (#1745) * Add update-specs updatcli workflow * Fix paths * Required Status Check (#1749) * Create single status check that can be set as required * Let windows test runs exit with the correct exit code * Set the exit code * Formatting * fix * More readable jq query * Set status check to success in case it's an only-docs PR (#1753) * Set status check to success in case it's a only-docs PR * Set permissions * fix path patterns * Add comments * Update badge (#1752) * Add dynamic config tag to more supported options (#1750) * Fix sha source (#1754) * update changelog --------- Co-authored-by: Jan Calanog <nejcalanog@gmail.com> Co-authored-by: Colton Myers <colton@basepi.net> Co-authored-by: Jan Calanog <jan.calanog@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Sets the
test / allstatus check to green in case it's a only-docs PR and the test.yml workflow is not triggered.This is needed to be able to set
test / allas required status check.Related issues