Instrument aws elb serverless requests

[tonyman19]

This PR lets instrument elb serverless requests.

When lambda is being connected directly to ALB (this is useful when you want to rewrite some ECS existing endpoints with their lambda counterparts)

It fixes the bugs for full url creation for api gw ver 1 (when url is formed from queryStringParameters collection):

1. full url was not properly formed with parameters (& were missing between key=value elements)
2. url encoding was not applied to key / value pairs inside url

Related issues

closes #1587

[cla-checker-service]

💚 CLA has been signed

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-08-09T14:11:26.293+0000

• Duration: 30 min 43 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4937
Skipped	3455
Total	8392

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /test linters : Run the Python linters only.

• /test full : Run the full matrix of tests.

• /test benchmark : Run the APM Agent Python benchmarks tests.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[tonyman19]

/test

[basepi]

This is really excellent, thank you! Just one minor change, and I'll also be opening a PR against the spec so we can make sure this is consistent across the serverless agents.

[basepi]

/test

[ghost]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (68/68)	💚
Files	100.0% (227/227)	💚
Classes	100.0% (227/227)	💚
Lines	89.738% (17324/19305)	👍 0.096
Conditionals	77.109% (3163/4102)	👍 0.24

[basepi]

I added the fix I recommended + a CHANGELOG entry

[basepi]

@tonyman19 Did you sign the CLA for the email anton@mycarly.com? That's the email attached to your commits.

[tonyman19]

Hi Colton, Thanks for your PR review and getting back to me. I've signed it with the ***@***.*** (same as my github account). ***@***.*** - this is my work email which I'm using for our elastic subscription - but the contribution will be from ***@***.*** In the attachment you can find the signed document (tried 3 times before and everytime missed the button to finish the signature - but was able to download PDFs :)) Best regards Anton Matviyenko

…

On Mon, 8 Aug 2022 at 20:51, Colton Myers ***@***.***> wrote: @tonyman19 <https://github.com/tonyman19> Did you sign the CLA for the email ***@***.***? That's the email attached to your commits. — Reply to this email directly, view it on GitHub <#1605 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAIKX6L2XNZSR3AVABYZATVYFJMBANCNFSM55VYITJQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tonyman19]

Hi Colton,

Thank you for review and quick reply. Finalized signing for anton.matviyenko@gmail.com
What about recorded commits - is it possible to change from anton@mycarly.com to the abovementioned email?
Or is it ok the way they are ATM?
Will sign the CLA for anton@mycarly.com as well.

[tonyman19]

Short question about following inconsistency that I have found. Is it by purpose or just a mistake?

if self.source == "api": .... cloud_context["origin"]["account"] = {"id": self.event["requestContext"]["accountId"]} elif self.source == "sns": ..... cloud_context["origin"]["account_id"] = record["Sns"]["TopicArn"].split(":")[4] 

So first time (and everywhere else) we are creating subobject with id field ["origin"]["account"]["id"] - next time we create subelement account_id which is located under ["origin"]["account_id"].

Should we also fix that here?

[tonyman19]

Regarding your removal of:

service_context["origin"]["version"] = self.event.get("version", "1.0") 

version field is also absent for rest (or http integrations) v1 (check aws_api_test_data.json)

I assumed that there might be a second version of elb integration where it will be present so I did it the same way. I did it conforming the spec for api gw: https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws-lambda.md#api-gateway-v1--v2

context.service.origin.version	e.g. 1.0	1.0 for API Gateway V1, 2.0 for API Gateway V2.	event.version (or 1.0 if that field is not present)

[basepi]

I suppose there could be a v2 for ELB some day. We did it that way for API Gateway because there were two prominent (and quite different) versions in use when we launched the integration. I think since there's only one version of ELB right now, we'll leave off the version (like we do for the other non-http triggers), and we can add it in the future if it becomes relevant.

Thanks for signing the CLA with the correct email. I can't change the email on the commits, you would have to re-configure your git client and then rebase the commits. But everything is good now that you signed the CLA for the correct email.

Good catch on the SNS account_id -- that was definitely a bug! I have fixed it.