Skip to content

Conversation

beniwohli
Copy link
Contributor

What does this pull request do?

For SQS, span links are implemented by instrumenting ReceiveMessage and attaching a reference to each messages TraceParent as a span link to the ReceiveMessage span.

Related issues

closes #1473

@ghost
Copy link

ghost commented Jun 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-21T09:24:14.698+0000

  • Duration: 34 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 4909
Skipped 3455
Total 8364

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link

ghost commented Jun 20, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.608% (17220/19217) 👍 0.021
Conditionals 76.748% (3139/4090) 👍 0.093
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@beniwohli beniwohli enabled auto-merge (squash) June 21, 2022 06:41
@beniwohli beniwohli merged commit 212e2a6 into elastic:main Jun 21, 2022
@beniwohli beniwohli deleted the sqs-span-links branch June 23, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants