Celery contrib: read custom parent span id from the task headers #1500
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
In a complex Celery workflow, tasks might be invoked in a chain like this:
In such setting, because the current Celery instrument only propagates the first caller's traceparent, all downstream tasks share the same traceparent from A. This might be undesirable if every task should be regarded as a subtask of its caller.
For instance, "submit_task_for_computation" initiates "do_heavy_lifting" and waits for completion so that it can immediately rollback a database transaction if the job failed. But instead of correlate do_heavy_lifting with submit_task_for_computation, current instrument produces the following trace:
Whereas we actually hope for this:
This PR is to allow a caller task to set the receiver task's parent span by passing a
parent_span_id
in the Celery headers.I have prepared this snippet as a demo.