aiohttp exceptions can be normal responses #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In aiohttp HTTPExceptions inherit from Response and can have a status that is not 500. It even has a HTTPOk exception with a 200 status code that can be raised. Capturing these exception as errors in APM creates a falls view of response and service health. This changes the aiohttp middleware to handle HTTPExceptions different from other exceptions. It only captures HTTPExceptions equal or above a 500 status and handles all others like a success.
houndci-bot reviewed Nov 6, 2021
github-actions bot added agent-python community 
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
beniwohli approved these changes Nov 8, 2021
| /test |
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
In
aiohttpHTTPExceptionsinherit fromResponseand can have a statusthat is < 500. It even has a
HTTPOkexception with a 200 status codethat can be raised.
Capturing these exceptions as errors in APM creates a fall's view of
response and service health.
This changes the
aiohttpmiddleware to handleHTTPExceptionsdifferentfrom other exceptions. It only captures
HTTPExceptionsequal or above a500 status and handles all others like a success.