More AWS Lambda improvements and spec changes #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Better error handling for the Xxx conversion, and also use the case-insensitive status_code everywhere
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
beniwohli reviewed Nov 5, 2021
This reverts commit 7f148e5.
| Thanks to @trentm for pointing out my bad assumption about case-sensitivity of |
basepi changed the title beniwohli approved these changes Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Better error handling for the
Xxxconversion, and remove case-insensitivestatusCodehandling, as anything besidesstatusCodeis invalid and will throw a server error.Edit: Also added the field changes from spec PR here: elastic/apm#540