Skip to content

fix issue in httpx instrumentation when request is a kwarg #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 30, 2021
Merged

fix issue in httpx instrumentation when request is a kwarg #1337

merged 6 commits into from
Sep 30, 2021

Conversation

beniwohli
Copy link
Contributor

The issue is that some_dict.get("x", alt) doesn't short-circuit,
so alt is always evaluated.

closes #1336
@beniwohli
fix issue in httpx instrumentation when request is a kwarg
d8e0c83 
The issue is that some_dict.get("x", alt) doesn't short-circuit, so alt is always evaluated. closes elastic#1336
@beniwohli beniwohli requested a review from basepi September 22, 2021 12:12
@beniwohli beniwohli mentioned this pull request Sep 22, 2021
Closed
@ghost
Copy link

ghost commented Sep 22, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-29T14:30:20.478+0000

  • Duration: 33 min 9 sec

  • Commit: ce3abdc

Test stats 🧪

Test Results
Failed 0
Passed 9603
Skipped 8607
Total 18210

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@beniwohli beniwohli merged commit f68d225 into elastic:master Sep 30, 2021
@beniwohli beniwohli deleted the fix-1336 branch September 30, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python
2 participants
@beniwohli @basepi