- Notifications
You must be signed in to change notification settings - Fork 231
AWS Lambda support #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Lambda support #1193
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
* Add disable_metrics_thread conf * Only use the transport background thread * Singleton client for the whole lambda file * Flush after transaction
This reverts commit 84ead98.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding time_to_perf_counter
, it generally LGTM. I worry however that especially in an environment like Lambda, where the runtime is put to sleep and woken up on a regular basis, clock skew could be a phenomenon that is more regular than usual. But that's just a hunch...
I don't think that's actually an issue in this case. Edit: I am going to do some testing around |
Did some testing today and the conversion measurement we take at the beginning of the cold start appears to stay accurate throughout multiple invocations, with freezes in between. I'm still going to implement some re-measurement for long-running processes but I don't think we need to measure every time with Lambda like I was fearing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, looks good!
I think we need a better solution for passing state along in the capture_serverless
object. Especially when used as a module-level decorator, the chance of things going awry are pretty big IMO.
Remaining:
Related issues
Ref #428