bump log level for multiple set_client calls to WARNING #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
it turns out that setting the agent multiple times can result in difficult-to-debug issues, especially when initially using the DjangoClient, and having it replaced with a "bare" Client. See elastic#1093, elastic#1148 By bumping this log message to WARNING, it is a bit more obvious what the problem could be.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
basepi approved these changes Jun 14, 2021
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
it turns out that setting the agent multiple times can result in difficult-to-debug issues, especially when initially using the DjangoClient, and having it replaced with a "bare" Client. See elastic#1093, elastic#1148 By bumping this log message to WARNING, it is a bit more obvious what the problem could be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
it turns out that setting the agent multiple times can
result in difficult-to-debug issues, especially when
initially using the DjangoClient, and having it replaced
with a "bare" Client. See #1093, #1148
By bumping this log message to WARNING, it is a bit more
obvious what the problem could be.