Skip to content

Fix httpx 0.18.0 #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2021
Merged

Fix httpx 0.18.0 #1118

merged 2 commits into from
Apr 27, 2021

Conversation

beniwohli
Copy link
Contributor

The newly released httpx 0.18.0 and its dependency httpcore 0.13 changed some internals that affect us.
@ghost
Copy link

ghost commented Apr 27, 2021

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1118 opened

  • Start Time: 2021-04-27T15:54:02.991+0000

  • Duration: 21 min 53 sec

  • Commit: b703aeb

Test stats 🧪

Test Results
Failed 1
Passed 8575
Skipped 7993
Total 16569

Trends 🧪

Image of Build Times

Image of Tests

Test errors 1

Expand to view the tests failures

Initializing / Test / windows-3.8-none / tests.instrumentation.asyncio_tests.async_elasticsearch_client_tests –
    Expand to view the error details

     collection failure

    Expand to view the stacktrace

     ImportError while importing test module 'C:\Users\jenkins\workspace\hon_apm-agent-python-mbp_PR-1118\src\github.com\elastic\apm-agent-python\tests\instrumentation\asyncio_tests\async_elasticsearch_client_tests.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: C:\Python38\lib\importlib\__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests\instrumentation\asyncio_tests\async_elasticsearch_client_tests.py:39: in <module> from elasticsearch import AsyncElasticsearch E ImportError: cannot import name 'AsyncElasticsearch' from 'elasticsearch' (C:\Python38\lib\site-packages\elasticsearch\__init__.py)

Steps errors 3

Expand to view the steps failures

Run tests
  • Took 0 min 17 sec . View more details on here
  • Description: .\scripts\run-tests.bat
Archive the artifacts
  • Took 0 min 0 sec . View more details on here
  • Description: [2021-04-27T16:14:53.430Z] Archiving artifacts hudson.AbortException: script returned exit code 1
Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: hudson.AbortException: script returned exit code 1

Log output

Expand to view the last 100 lines of log output 

[2021-04-27T16:14:17.600Z] + python3 -m coverage combine [2021-04-27T16:14:49.758Z] + python3 -m coverage xml [2021-04-27T16:14:52.360Z] [Cobertura] Skipping Cobertura coverage report as build was not SUCCESS or better ... [2021-04-27T16:14:52.360Z] [2021-04-27T16:14:52.843Z] + curl -sLO https://code.jquery.com/jquery-3.3.1.slim.min.js [2021-04-27T16:14:53.164Z] + curl -sLO https://cdn.jsdelivr.net/npm/htmlson.js@1.0.4/src/htmlson.js [2021-04-27T16:14:53.430Z] Archiving artifacts [2021-04-27T16:14:53.644Z] Stage "Building packages" skipped due to earlier failure(s) [2021-04-27T16:14:53.758Z] Stage "Integration Tests" skipped due to earlier failure(s) [2021-04-27T16:14:53.873Z] Stage "Benchmarks" skipped due to earlier failure(s) [2021-04-27T16:14:54.145Z] Stage "Prepare Release" skipped due to earlier failure(s) [2021-04-27T16:14:54.207Z] Stage "Prepare Release" skipped due to earlier failure(s) [2021-04-27T16:14:54.330Z] Stage "Prepare Release" skipped due to earlier failure(s) [2021-04-27T16:14:54.457Z] Stage "Prepare Release" skipped due to earlier failure(s) [2021-04-27T16:14:55.023Z] Running on Jenkins in /var/lib/jenkins/workspace/hon_apm-agent-python-mbp_PR-1118 [2021-04-27T16:14:55.210Z] [INFO] getVaultSecret: Getting secrets [2021-04-27T16:14:55.278Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID [2021-04-27T16:14:56.402Z] + chmod 755 generate-build-data.sh [2021-04-27T16:14:56.403Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1118/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1118/runs/1 FAILURE 1253135 [2021-04-27T16:14:56.403Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1118/runs/1/steps/?limit=10000 -o steps-info.json

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Test stats 🧪

Test Results
Failed 1
Passed 8575
Skipped 7993
Total 16569

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / Test / windows-3.8-none / tests.instrumentation.asyncio_tests.async_elasticsearch_client_tests –

@beniwohli
Copy link
Contributor Author

test failure is unrelated
@beniwohli beniwohli merged commit b5d183d into elastic:master Apr 27, 2021
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@beniwohli
Fix httpx 0.18.0 (elastic#1118)
87f8fc8 
* Since 0.18.0, requesting `http://` raises an `UnsupportedProtocol` error * the method we instrument has been renamed in httpcore 0.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python
1 participant
@beniwohli