Skip to content

Conversation

Sparkycz
Copy link
Contributor

What does this pull request do?

Adds http.status_code and db.row_affected from ElasticSearch response in ES instrumentation

Related issues

closes #354

@Sparkycz Sparkycz force-pushed the es-search-instrumentation-detail branch from 92bbdd9 to 9913099 Compare April 21, 2021 16:50
@ghost
Copy link

ghost commented Apr 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1108 updated

  • Start Time: 2021-06-28T14:51:34.254+0000

  • Duration: 26 min 10 sec

  • Commit: 7e89b0c

Test stats 🧪

Test Results
Failed 0
Passed 9481
Skipped 8604
Total 18085

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9481
Skipped 8604
Total 18085

@AlexanderWert AlexanderWert added this to the 7.14 milestone Apr 29, 2021
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks for grabbing this!

@basepi
Copy link
Contributor

basepi commented Jun 21, 2021

I'm a bit mystified as to why the tests are failing. I'll keep digging but the result_data["hits"]["total"]["value"] should definitely be working based on my local testing.

@basepi
Copy link
Contributor

basepi commented Jun 22, 2021

I spoofed the tests to point to my local elasticsearch instance and they passed. I'm going to investigate the elasticsearch that's used in the integration tests (https://github.com/elastic/apm-integration-testing) -- I'm guessing the issue is there.

@basepi
Copy link
Contributor

basepi commented Jun 22, 2021

Oh, I figured it out. It's failing against Elasticsearch 2.x (which is not surprising). Just need to add some conditionals. Stay tuned.

@basepi basepi merged commit ee75cb8 into elastic:master Jun 29, 2021
@Sparkycz Sparkycz deleted the es-search-instrumentation-detail branch July 1, 2021 04:15
@Sparkycz
Copy link
Contributor Author

Sparkycz commented Jul 1, 2021

Thanks a lot for finishing the change. I’ve been out of Github for a while..

beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
* Add some data about response data at ES instrumentation * Update docs * Fix failing tests * Fix typo (rows_affected not row_affected) and tests * Update CHANGELOG Co-authored-by: Colton Myers <colton.myers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants