Fix AWS instrumentation destination.service.resource handling #2947
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #2946, closes #2849 .
While implementing these fixes I enhanced the test cases of all AWS instrumentations to check for the correct
service.target.*
anddestination.service.resource
fields.These tests unconvered that at least to my reading we currently deviate from the spec for
DynamoDB
:Currently
service.target.name
is alwaysnull
forDynamoDB
, according to the spec it should be the AWS region instead.I changed the
DynamoDB
instrumentation to follow the spec with this PR aswell. If my reading is wrong here, we should remove this change from the PR.Checklist