Skip to content

Conversation

@LikeTheSalad
Copy link
Contributor

Closes #195

bryce-b
bryce-b previously approved these changes Oct 19, 2023
@ty-elastic
Copy link

looks great to me! thank you!!

bmorelli25
bmorelli25 previously approved these changes Oct 19, 2023
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions for the docs. Looks good!

@LikeTheSalad LikeTheSalad dismissed stale reviews from bmorelli25 and bryce-b via f172e9b October 23, 2023 07:11
LikeTheSalad and others added 7 commits October 23, 2023 09:11
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
@LikeTheSalad LikeTheSalad merged commit 300ae3a into main Oct 24, 2023
@LikeTheSalad LikeTheSalad deleted the 195-provide-config-option-to-choose-grpc-or-http-exporters branch October 24, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment