Add signal filtering api #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LikeTheSalad requested review from AlexanderWert, bryce-b, felixbarny and gregkalapos 
LikeTheSalad commented Apr 28, 2023
| return this; | ||
| } | ||
| | ||
| /** |
There was a problem hiding this comment.
In the end, I figured that, at least in Android, setting the filters with a function named set* might be better in order to keep consistency with all the other config options @bryce-b @gregkalapos jsyk
| I think we should allow for filter chaining. By this I mean allowing multiple filters to be set. Instead of |
| Sounds good, I just added filter chaining support @bryce-b |
bryce-b approved these changes May 2, 2023
…to 158-add-signal-filtering-api
bmorelli25 approved these changes May 8, 2023
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #158