feat: curl return promise #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @popomore and @atian25 to be potential reviewers. |
fengmk2 approved these changes Feb 9, 2017
atian25 approved these changes Feb 9, 2017
Member
atian25 left a comment
atian25 left a comment There was a problem hiding this comment.
+1 早点改, 这个就不会 bug 了, 哈哈
https://github.com/eggjs/egg/pull/264/files#diff-f2d3e431df83d39bb2f206192ebde2b4L199
Codecov Report@@ Coverage Diff @@ ## master #342 +/- ## ===================================== Coverage 100% 100% ===================================== Files 28 28 Lines 635 635 ===================================== Hits 635 635
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
curl
Description of change
curl return promise to support async functions