Feat search empty query #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
sguiheux approved these changes Mar 20, 2018
| Hey, thank you for the PR! Something has gone wrong though, it's including lots of locale files that shouldn't be there - could you check that out please? Could you also write a line about what exactly this PR is setting out to achieve, and why? Thanks! |
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
| sorry @edcarroll for the bad formatted PR. It's better now :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request add the ability to display instantly a list even if there aren't any query (with the allowEmptyQuery option) and another option named resetQueryOnChange to not reset the query when the options list changed.
It's very useful for my use-case which is to have a search bar with recent elements displayed when no query is indicated and when we write a query it change the options list to display all the items available.