Skip to content

refactor(material-renderers): remove deprecated prop #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

refactor(material-renderers): remove deprecated prop #2437

merged 3 commits into from
Apr 14, 2025

Conversation

johannesss
Copy link
Contributor

remove deprecated prop button of ListItem and use ListItemButton instead.

fixes #2426
@netlify Netlify
Copy link

netlify bot commented Apr 14, 2025 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 44ddfc7
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/67fce9ca98847000085261bb
😎 Deploy Preview https://deploy-preview-2437--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
@lucas-koehler
Copy link
Contributor

Hi @johannesss , thanks for the contribution ❤️
The change itself looks good but is missing adapting the tests in MaterialListWithDetailRenderer.test.tsx as they still check for presence of ListItems. Please adapt them, too :)
@johannesss
Copy link
Contributor Author

Hi @johannesss , thanks for the contribution ❤️ The change itself looks good but is missing adapting the tests in MaterialListWithDetailRenderer.test.tsx as they still check for presence of ListItems. Please adapt them, too :)

Ohhh, okay! Will do!
@coveralls
Copy link

Coverage Status

coverage: 82.517%. remained the same
when pulling 44ddfc7 on johannesss:fix/material-deprecated-prop
into 9a60420 on eclipsesource:master.
lucas-koehler
lucas-koehler approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks for the contribution and the updates!
@lucas-koehler lucas-koehler merged commit 5218263 into eclipsesource:master Apr 14, 2025
8 checks passed
@lucas-koehler lucas-koehler modified the milestone: 3.6 Apr 14, 2025
@johannesss johannesss deleted the fix/material-deprecated-prop branch April 14, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

material react

3 participants

@johannesss @lucas-koehler @coveralls