dev: Update pnpm to latest v10.4.1 and fix compatibility with Netlify #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Update to lockfile version 9 without updating dependencies - Add npm corepack configuration for pnpm 9.15.6 (latest 9.x) - Set lower bound for pnpm tp 9.15.4 (currently used by Netlify) - Update dev container
- Update README, dev container and corepack reference - No lockfile changes are necessary relative to pnpm 9
Remove pnpm version from CI workflows to use the version specified in the root package.json's `packageManager` property. This property is set by npm corepack. Also update the pnpm setup actions and pin them to a fixed commit hash.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| Netflify seems to adhere to the packagemanger configured by corepack as can be seen in this deploy log: https://app.netlify.com/sites/jsonforms-examples/deploys/67bc9aa8ca12af0008449438. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
^10.4.1. As Netlify uses the version specified by corepack (see dev: Update pnpm to latest v10.4.1 and fix compatibility with Netlify #2422 (comment)), this should not be a problem.packageManager. This is supported by pnpm-setup action.