Skip to content

Conversation

Maxouwell
Copy link
Contributor

Tentative PR for #2285

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit e15357a
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65d37ca76a32e900082da96e
😎 Deploy Preview https://deploy-preview-2286--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler
Copy link
Contributor

Hi @Maxouwell , thanks for the PR ❤️ We'll have a look soon.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution ❤️

@sdirix
Copy link
Member

sdirix commented Feb 19, 2024

@Maxouwell There is still some type error in the test, can you take a look?

@Maxouwell
Copy link
Contributor Author

Maxouwell commented Feb 19, 2024

Lookink into it

@Maxouwell
Copy link
Contributor Author

Maxouwell commented Feb 19, 2024

I can't reproduct the error on my side, I explicitly made the empty test array data an any[] type to look if it please jest

@coveralls
Copy link

Coverage Status

coverage: 84.861% (+0.07%) from 84.796%
when pulling e15357a on Maxouwell:fix/material-array-layout-translated-no-data
into 072caa5 on eclipsesource:master.

@sdirix sdirix merged commit 1d73eb7 into eclipsesource:master Feb 20, 2024
@Maxouwell Maxouwell deleted the fix/material-array-layout-translated-no-data branch February 20, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants