Skip to content

Fix vue2 control type #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix vue2 control type #2088

merged 1 commit into from
Feb 9, 2023

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Feb 1, 2023

Changes the control type from Required<R> to ComputedRef<Required<R>>.

Fixes #1967
@netlify
Copy link

netlify bot commented Feb 1, 2023 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit fdca4ca
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63da6301d611c30008fc7fb0
😎 Deploy Preview https://deploy-preview-2088--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
@TheZoker TheZoker mentioned this pull request Feb 1, 2023
Open
@coveralls
Copy link

Coverage Status

Coverage: 83.193%. Remained the same when pulling fdca4ca on TheZoker:fix-vue-type-issue into 1b22f55 on eclipsesource:master.
sdirix
sdirix approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@sdirix sdirix merged commit b77a4be into eclipsesource:master Feb 9, 2023
@TheZoker TheZoker deleted the fix-vue-type-issue branch February 9, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@TheZoker @coveralls @sdirix