Skip to content

Conversation

brockfanning
Copy link
Contributor

The intended behavior here is that if a boolean control has a description, then it will appear as a tooltip. However if showUnfocusedDescription is true, then the description appears below as text. I tried to copy as much code from existing components as possible, but I'm happy to make any changes as needed.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 6ff90d0
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63bc198ba9176000096b2185
😎 Deploy Preview https://deploy-preview-2072--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 9, 2023

Coverage Status

Coverage: 83.193%. Remained the same when pulling d292be4 on brockfanning:mui-checkbox-with-description into 3b32c9b on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @brockfanning, thank you very much for your contribution :)
I tested it and it seems to work well.

I have two requests:

  1. Could you extend one the examples to contain a description for the boolean control. E.g. you could extend packages/examples/src/examples/control-options.ts
  2. Could you also add this behavior to the MaterialBooleanToggleControl as well? This way both boolean controls behave consistently.
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates and again for the contribution :)
CI did not run again due to a first time contributor. However, I executed the build and unit tests locally and they still worked :)

@lucas-koehler lucas-koehler merged commit 36e3732 into eclipsesource:master Jan 9, 2023
@lucas-koehler lucas-koehler added this to the 3.1 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants