Skip to content

Conversation

Tarjei400
Copy link
Contributor

Added add and remove icons for Table renderer

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2022

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Sep 21, 2022

Thanks for the contribution ❤️. We will take a look right after the 3.0 release.

@Tarjei400
Copy link
Contributor Author

@sdirix let me know if I can be of any assistance

@sdirix sdirix requested a review from lucas-koehler October 4, 2022 10:09
@coveralls
Copy link

coveralls commented Oct 17, 2022

Coverage Status

Coverage increased (+0.5%) to 84.866% when pulling e773be5 on t3chy0n:master into 79e1c56 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tarjei400 Thanks again for the contribution :) The add and remove buttons already work great for me. I added some suggestions regarding the buttons itself. Could you take a look at them please?

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I just have two minor comments left.

@lucas-koehler lucas-koehler linked an issue Oct 18, 2022 that may be closed by this pull request
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the updates. LGTM now :)

@lucas-koehler lucas-koehler merged commit 7206141 into eclipsesource:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants