Skip to content

Conversation

JoshuaFortriede
Copy link
Contributor

use of lodash startCase was changing the values of enum values used a labels. Removed function and import.

use of lodash startCase was changing the values of enum values used a labels. Removed function and import.
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2022

CLA assistant check
All committers have signed the CLA.

@sdirix sdirix self-requested a review March 29, 2022 08:49
@sdirix
Copy link
Member

sdirix commented Apr 6, 2022

Hi @JoshuaFortriede! Thanks for the pull request! Are you able to also fix the now failing test cases?

@sdirix sdirix linked an issue Apr 7, 2022 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.29% when pulling 3074e33 on JoshuaFortriede:fix/enum_array_label_display_#1903 into d65d7eb on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sdirix sdirix merged commit d04e851 into eclipsesource:master May 5, 2022
@sdirix sdirix added this to the 3.0 milestone May 5, 2022
@sdirix sdirix changed the title remove lodash startCase from label of checkboxes #1903 Preserve enum labels in React Material enum array May 5, 2022
@sdirix sdirix removed this from the 3.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants