Use default calculated i18n keys #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If there is no 'i18n' key in schema or ui schema a default calculated key based on the data path of the respective control is used. Additionally fixes the issue that the 'required' message of localized errors were overwritten by JSON Forms.
AlexandraBuzila approved these changes Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If there is no 'i18n' key in schema or ui schema a default
calculated key based on the data path of the respective control
is used.
Additionally fixes the issue that the 'required' message of
localized errors were overwritten by JSON Forms.
Also removed redundant exports in JSON Forms core and
cleans up imports in test cases which lead to errors when
executing ava.