Free monitorEnterRecordPool in freecontinuation #22792
Merged
+3 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tajila force-pushed the user branch 2 times, most recently from 4e8b114 to be20f4a Compare | jenkins test sanity xlinux64 jdk25 |
| jenkins test sanity alinux64 jdk25 |
| machine issues, Ill try the test again |
| jenkins test sanity alinux64 jdk25 |
| jenkins compile xlinux jdk25 |
| Lots of |
Currently, the monitor enter record pool is only free'd when the continuation is removed from the continuation cache. This behaviour causes memory leaks as a continuation may never be removed from the cache. Additionally, when allocate a new continuation each time enterContinuation is called. This PR takes the conservative approach of free the monitor records as soon as the continuation is free'd. In future we should consider if the monitor records can be persisted run to run. Currently, this has not been tested yet. Fixes: eclipse-openj9#22776 Signed-off-by: tajila <atobia@ca.ibm.com>
| jenkins test sanity alinux64 jdk25 |
| jenkins test sanity.openjdk amac jdk25 |
| timeout in java/lang/Thread/virtual/Collectable.java which is #18463 |
babsingh approved these changes Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, the monitor enter record pool is only free'd when the
continuation is removed from the continuation cache. This behaviour
causes memory leaks as a continuation may never be removed from the
cache.
Additionally, when allocate a new continuation each time
enterContinuation is called.
This PR takes the conservative approach of free the monitor records as
soon as the continuation is free'd. In future we should consider if the
monitor records can be persisted run to run. Currently, this has not
been tested yet.
Fixes: #22776