- Notifications
You must be signed in to change notification settings - Fork 151
Closed
Description
See this constructor:
lsp4j/org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Lines 107 to 110 in cc20058
| @Deprecated | |
| new(Boolean documentChanges) { | |
| this.documentChanges = documentChanges | |
| } |
It is unclear why it was deprecated. This deprecation notice has been added in commit 43a0e07, seemingly after a review in #277 and deprecation of Boolean resourceChanges member of the same type.
Perhaps @yaohaizh just mistaken resourceChanges and documentChanges while doing that? Anyway, I think it's a good idea to add an explanation to the deprecation notice (it looks like you can just safely use setDocumentChanges instead). Optionally, we may un-deprecate the constructor in question.