Skip to content

Why is WorkspaceEditCapabilities's constructor setting documentChanges is deprecated? #822

@ForNeVeR

Description

@ForNeVeR

See this constructor:

@Deprecated
new(Boolean documentChanges) {
this.documentChanges = documentChanges
}

It is unclear why it was deprecated. This deprecation notice has been added in commit 43a0e07, seemingly after a review in #277 and deprecation of Boolean resourceChanges member of the same type.

Perhaps @yaohaizh just mistaken resourceChanges and documentChanges while doing that? Anyway, I think it's a good idea to add an explanation to the deprecation notice (it looks like you can just safely use setDocumentChanges instead). Optionally, we may un-deprecate the constructor in question.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions