Skip to content

Conversation

strengejacke
Copy link
Member

No description provided.

@strengejacke strengejacke marked this pull request as ready for review October 10, 2025 09:38
@strengejacke strengejacke requested a review from Copilot October 15, 2025 12:23
@strengejacke
Copy link
Member Author

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for svyolr models (survey-weighted ordinal logistic regression) from the survey package. The changes integrate svyolr models with the existing polr model handling patterns throughout the codebase.

  • Added test coverage for svyolr model parameters extraction
  • Extended existing polr handling to include svyolr models across multiple functions
  • Added specific method definitions for svyolr models in the survey methods

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/testthat/test-svyolr.R New test file validating svyolr model parameter extraction
R/pool_parameters.R Extended exception handling and formatting to include svyolr models
R/parameters_type.R Added svyolr to parameter type checking alongside polr
R/methods_survey.R Added svyolr method definitions and updated parameter assignment
R/format_parameters.R Extended parameter formatting to handle svyolr models
R/extract_parameters.R Added svyolr support in parameter extraction logic
R/dof.R Included svyolr in degrees of freedom validation
R/1_model_parameters.R Added svyolr to CI method selection logic
NAMESPACE Updated exports to include svyolr method
DESCRIPTION Version bump to reflect new functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@strengejacke strengejacke merged commit 2d04732 into main Oct 15, 2025
15 of 20 checks passed
@strengejacke strengejacke deleted the svyolr branch October 15, 2025 12:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for svyolr models and includes a number of stylistic code refactorings. The core changes for svyolr support seem correct, leveraging existing methods for similar model types like polr and glm. A new test file for svyolr has been added, which is great for ensuring correctness. However, I've identified a critical syntax error in R/dof.R where a function is closed prematurely, which could lead to incorrect behavior. This should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant