Skip to content

Conversation

@nelsonic
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 10, 2017

Codecov Report

Merging #28 into master will increase coverage by 4.65%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #28 +/- ## ======================================== + Coverage 95.34% 100% +4.65%  ======================================== Files 1 1 Lines 43 43 ======================================== + Hits 41 43 +2  + Misses 2 0 -2
Impacted Files Coverage Δ
examples/counter-reset/counter.js 100% <0%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2f553...f4e81bf. Read the comment docs.

@nelsonic
Copy link
Member Author

I know I'm a "freak" but the "95% Coverage" Was Bugging me!!
image

image
https://youtu.be/btO3kE2RrEY

@iteles please review/merge when you can. thanks!

@nelsonic
Copy link
Member Author

@iteles review/merge not "urgent". but would be nice to get the "Tweet" done on Monday. 😉

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thanks for getting this ready for the 'big time' @nelsonic 😉

var state = root.getElementsByClassName('count')[0].textContent;
assert.equal(state, 0, "State is 0 (Zero) after reset."); // state was successfully reset to 0!
empty(root); // clean up after tests
// console.log('STATE:', state);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of commented out console.logs but I'm happy to leave them in for the time being as these might actually be useful to beginners when we publicise the tutorial #29

assert.equal(result, 0);
});

// please make this test pass if you know how! thanks! :-)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth also opening an issue on this 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please feel free to open that issue. thanks. 👍

@iteles
Copy link
Member

iteles commented Jun 11, 2017

I love how you hearted the codecov comment here 😆

@iteles iteles merged commit d17b772 into master Jun 11, 2017
@iteles iteles deleted the update-jsdom-fixes-click-tests branch June 11, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants