Skip to content

Bugfix user_inputs side effect in RANKED_DICTIONARIES #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix user_inputs side effect in RANKED_DICTIONARIES #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e755397
add failing test on user_inputs side effects
May 7, 2025
aa9ed64
Clear _ranked_dictionaries['user_inputs'] when no user_inputs given
May 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/zxcvbn_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,13 @@ def test_empty_password():
zxcvbn(password, user_inputs=[input_])
except IndexError as ie:
assert False, "Empty password raised IndexError"


def test_user_inputs_side_effects():
password = '7r3iz3|)0uz3'
input_ = [password]

guess1 = zxcvbn(password)['guesses_log10']
zxcvbn('somepassword', user_inputs=input_)
guess2 = zxcvbn(password)['guesses_log10']
assert abs(guess1 - guess2) < 1
2 changes: 2 additions & 0 deletions zxcvbn/matching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ def wrapper(*args, **kwargs):
def omnimatch(password, _ranked_dictionaries=None, user_inputs=[]):
if len(user_inputs):
_ranked_dictionaries['user_inputs'] = build_ranked_dict(user_inputs)
elif 'user_inputs' in _ranked_dictionaries:
del(_ranked_dictionaries['user_inputs'])

matches = []
for matcher in [
Expand Down