Skip to content

SERP Settings Sync: Update hide ai generated icon #7027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2025
Merged

SERP Settings Sync: Update hide ai generated icon #7027

merged 5 commits into from
Oct 30, 2025

Conversation

@mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Oct 29, 2025 •
edited by marcosholgado
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211738764657607?focus=true

Description

  • Moved the "Hide AI Generated Images" option visibility logic from the Activity to the ViewModel
  • Updated the AI image icon to use the new ic_image_ai_hide_24 icon

Steps to test this PR

Designs

Hide AI-Generated Images Option

  • Enable the feature toggle hideAiGeneratedImagesOption
  • Open AI Features settings
  • Verify the "Hide AI-Generated Images" option is visible with the updated icon
  • Switch to dark theme and check it matches "Search Assist Settings" in terms of theming
  • Tap on the option and verify it opens the correct embedded settings page with "Hide AI generated images" focused at the top of the screen

Hide AI-Generated Images In Prod

Prerequisite: You should delete @Toggle.InternalAlwaysEnabled from the hideAiGeneratedImagesOption feature toggle so you can toggle it in app

  • Disable the feature toggle hideAiGeneratedImagesOption
  • Open AI Features settings
  • Verify the "Hide AI-Generated Images" option is not visible

UI changes

Before After
Screenshot_20251029_173901 Screenshot_20251029_172331
Screenshot_20251029_173909 Screenshot_20251029_172323
@mikescamell mikescamell force-pushed the feature/mike/serp-settings-sync/add-new-hide-ai-images-icon branch from 6483b18 to 6642f89 Compare October 29, 2025 17:37
@mikescamell mikescamell marked this pull request as ready for review October 29, 2025 18:03
marcosholgado
marcosholgado approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just CI failing with some formatting stuff but feel free to merge once that's solved.
@mikescamell mikescamell merged commit a8d8e67 into develop Oct 30, 2025
6 checks passed
@mikescamell mikescamell deleted the feature/mike/serp-settings-sync/add-new-hide-ai-images-icon branch October 30, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mikescamell @marcosholgado