SERP Settings Sync: Add initial js message handlers #7013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikescamell force-pushed the feature/mike/serp-settings-sync/add-js-message-handlers branch 4 times, most recently from 413b71f to 17690e9 Compare mikescamell changed the title 
…ttings synchronization
mikescamell force-pushed the feature/mike/serp-settings-sync/add-js-message-handlers branch 2 times, most recently from 9ebdf81 to 8d6e583 Compare There was a problem hiding this comment.
Pull Request Overview
This PR implements SERP (Search Engine Results Page) settings synchronization between web-based DuckDuckGo search pages and the native Android app. It introduces message handlers for bidirectional communication about settings and AI feature states.
Key changes:
- Adds JS message handlers for getting, updating, and opening native settings from SERP pages
- Implements Duck.ai setting synchronization between native app and SERP
- Updates domain validation logic to support subdomain matching using TLD+1
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| UpdateNativeSettingsHandler.kt | Handler to persist SERP setting changes to native storage |
| OpenNativeSettingsHandler.kt | Handler to open native settings screens from SERP |
| GetNativeSettingsHandler.kt | Handler to retrieve stored native settings for SERP |
| NativeDuckAiSettingChangedHandler.kt | Subscription handler to push native Duck.ai setting changes to SERP |
| IsNativeDuckAiEnabledHandler.kt | Handler to query Duck.ai toggle state from SERP |
| ContentScopeScriptsJsMessaging.kt | Updates domain validation to support subdomains via TLD+1 matching |
| SettingsWebViewClient.kt | New WebView client to inject JS plugins for settings pages |
| SettingsWebViewActivity.kt | Wires up the new WebView client when feature is enabled |
| build.gradle | Adds duckchat-api dependency for Duck.ai settings access |
| *HandlerTest.kt files | Test files validating handler configurations |
| ContentScopeScriptsJsMessagingTest.kt | Tests for subdomain matching and null URL handling |
...pl/src/main/java/com/duckduckgo/duckchat/impl/messaging/NativeDuckAiSettingChangedHandler.kt Outdated Show resolved Hide resolved
...ain/java/com/duckduckgo/contentscopescripts/impl/messaging/ContentScopeScriptsJsMessaging.kt Show resolved Hide resolved
.../java/com/duckduckgo/settings/impl/serpsettings/messaging/UpdateNativeSettingsHandlerTest.kt Outdated Show resolved Hide resolved
This has been changed to check against the eTLD+1 of the URL which will allow us to more easily use test urls such as someperson.duckduckgo.com a form of `isUrlAllowed()` is already being used in SubscriptionMessagingInterface
mikescamell force-pushed the feature/mike/serp-settings-sync/add-js-message-handlers branch 2 times, most recently from b525fc3 to 19918fc Compare …om SERP Placeholder for now, adding persistence and the rest in another PR
mikescamell force-pushed the feature/mike/serp-settings-sync/add-js-message-handlers branch from 19918fc to c41620e Compare 
marcosholgado approved these changes Oct 30, 2025
| setSupportZoom(true) | ||
| } | ||
| | ||
| if (settingsPageFeature.serpSettingsSync().isEnabled()) { |
There was a problem hiding this comment.
You also will need to eventually call register within the feature flag, I assume that's left for another PR, etc.
There was a problem hiding this comment.
Yep will do that in a future PR
mikescamell deleted the feature/mike/serp-settings-sync/add-js-message-handlers branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211756086814099?focus=true
Description
Adds handlers to sync settings between SERP and Native settings.
Steps to test this PR
See asana task for testing steps: https://app.asana.com/1/137249556945/project/72649045549333/task/1211783183780068?focus=true
UI changes
No UI changes in this PR. The feature is focused on backend integration between SERP and native settings.