Issue #2870040 by mglaman: Remove payment method from order if there … #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bojanz force-pushed the 8.x-2.x branch 5 times, most recently from 1028fc1 to 005e904 Compare 
mglaman force-pushed the 2870040-decline-order-payment-method branch from 69a6f15 to a0d6592 Compare 
| The test failures have to do with orders which have have payment gateway reference but no payment method. |
…is a decline exception
mglaman force-pushed the 2870040-decline-order-payment-method branch from a0d6592 to d705c25 Compare 
mglaman commented Apr 23, 2017
| catch (DeclineException $e) { | ||
| $message = $this->t('We encountered an error processing your payment method. Please verify your details and try again.'); | ||
| drupal_set_message($message, 'error'); | ||
| $this->order->get('payment_gateway')->setValue(NULL); |
There was a problem hiding this comment.
@bojanz If we do not remove this.. then the chain of logic here fails, which is another bug. Not sure if I should fix here or not.
$default_option = NULL; if ($order_payment_method) { $default_option = $order_payment_method->id(); } elseif ($order_payment_gateway && !($order_payment_gateway instanceof SupportsStoredPaymentMethodsInterface)) { $default_option = $order_payment_gateway->id(); } Returns payment gateway... which is not a method.
$selected_option = $pane_form['payment_method'][$default_option]; $payment_gateway = $payment_gateways[$selected_option['#payment_gateway']]; if ($payment_gateway->getPlugin() instanceof SupportsStoredPaymentMethodsInterface) { This supports no reconciliation for the fact we have a gateway ID. So I suppose the thing to do is remove returning gateway ID?
bojanz force-pushed the 8.x-2.x branch 2 times, most recently from 6be1d5c to b8a7444 Compare # Conflicts: # modules/payment/src/Plugin/Commerce/CheckoutPane/PaymentProcess.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…is a decline exception