Skip to content

Issue #2857378 by bojanz, vasike, mglaman: Hide order activity when empty #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: 8.x-2.x
Choose a base branch
from
Open

Issue #2857378 by bojanz, vasike, mglaman: Hide order activity when empty #666

wants to merge 16 commits into from

Conversation

vasike
Copy link
Contributor

@vasike vasike commented Mar 6, 2017

No description provided.

@mglaman
Copy link
Contributor

mglaman commented Mar 9, 2017

phpcs issues

The command "phpcs --standard=phpcs.xml src -s" exited with 0. 7.39s$ phpcs --standard=phpcs.xml modules -s FILE: ...erce/modules/log/tests/src/Functional/OrderAdminActivityTest.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 17 | ERROR | [x] Do not append variable name "$order" to the type | | declaration in a member variable comment | | (Drupal.Commenting.VariableComment.InlineVariableName) 68 | ERROR | [x] Expected 1 blank line after function; 0 found | | (Squiz.WhiteSpace.FunctionSpacing.After) 69 | ERROR | [x] The closing brace for the class must have an empty line | | before it | | (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------
@vasike
Copy link
Contributor Author

vasike commented Apr 6, 2017

it seems this fails because of this
#711
issue: https://www.drupal.org/node/2867430
@bojanz bojanz force-pushed the 8.x-2.x branch 5 times, most recently from 1028fc1 to 005e904 Compare April 21, 2017 19:23
@bojanz bojanz force-pushed the 8.x-2.x branch 2 times, most recently from 6be1d5c to b8a7444 Compare April 27, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vasike @mglaman