Added site information to CI and alpha job. #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AlexSkrypnyk added PR: DO NOT MERGE AlexSkrypnyk force-pushed the feature/11x-add-status-ci branch 2 times, most recently from ede77b7 to 2c61f48 Compare AlexSkrypnyk force-pushed the feature/11x-add-status-ci branch from 2c61f48 to 288bb0a Compare AlexSkrypnyk changed the title alpha job. AlexSkrypnyk force-pushed the feature/11x-add-status-ci branch from a16f1d4 to df6816c Compare 
AlexSkrypnyk commented May 29, 2024
| composer --verbose require --no-update drupal/core-recommended:^11@${{ matrix.drupal-release }} | ||
| composer --verbose require --no-update --dev drupal/core-dev:^11@${{ matrix.drupal-release }} | ||
| # Remove the line below once the package is out of `alpha`. | ||
| [[ ${{ matrix.drupal-release }} == 'beta' ]] && composer require chi-teck/drupal-code-generator:^4@alpha |
There was a problem hiding this comment.
this is unfortunate but a required temporary hack to unblock beta testing.
if consumer projects want to use minimum-stability: beta before this package is in beta - they can explicitly include this package in their composer.json using exactly this way
AlexSkrypnyk commented May 29, 2024
| - name: Run a single unit test to verify the testing setup | ||
| run: ./vendor/bin/phpunit -c ./web/core $(pwd)/web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php | ||
| run: ./vendor/bin/phpunit -c ./web/core "$(pwd)/web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php" |
There was a problem hiding this comment.
just fixing GHA linting issues (using actionlint).
AlexSkrypnyk added PR: Needs review AlexSkrypnyk commented May 29, 2024
normanlolx approved these changes Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TL;DR Our D11 CI is not in line with D10 CI leading to a coverage gap
The test jobs across D10 and D11 should be handling the same 3 types of releases:
current,nextandcanary. D10 already does this, but D11 does not.For a different Drupal version at a specific point in time Composer will resolve packages versions according to specific stability available at that time. We set that stability resolution as
minimum-stabilityincomposer.json.For D10, we currently testing exactly that.
For D11 we currently handle "current" as "next" and is missing what is currently set in
minimum-stability(the value isalpha) within abetaCI job: thedrupal/core-*packages are set asbetaincomposer.jsonbut other packages could be resolved asalpha.The table below describes current CI jobs of this project (as of 30 May 2024):
minimum-stabilityminimum-stabilitystablestablebetaalphabetabetadevdevdevdevThe table below describes proposed CI jobs of this project (as of 30 May 2024):
minimum-stabilityminimum-stabilitystablestablealpha*alpha*betabetabetabetadevdevdevdev* These will be changed to
stableonce D11 stable is out.This PR straightens things up by introducing a
alpha(perminimum-stability),beta, anddev.It also resets
drupal/core-*packages toalphato follow theminimum-stabilitycurrently set toalpha.Note that as of May 30th 2024, this will install D11
betabecause D11 is pastalpha, which is an expected and correct behaviour.Once D11 is stable, we would only have to:
minimum-stability: stableincomposer.jsondrupal/core-*versions to^11incomposer.jsonalphatostable.Changes
alphajob and updatedcomposer.jsonto servealphafordrupal/core-*packages to follow theminimum-stabilitycurrently set toalpha.devversion not being correctly installed fordevjob