Skip to content

Conversation

@AlexSkrypnyk
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk commented May 29, 2024

CI was not correctly handling the installation of dev deps - it was installing dev deps for 10.0 not 10.2 (or actually 10.4-dev). We were not able to pick this up because there is no information about the installed site.

In addition, currently dev is the "next next" version resolving 10.4-dev, while the "next" version is 10.3@beta. We are currently missing the "next" version.

This PR fixes all of the above.

Changes

  • Fixed dev version not being installed for dev job
  • Added beta version to capture "next beta"
  • Added installed site status information
Added_`beta`_testing_for_Drupal__·_drupal-composer_drupal-project_c68f84b
@AlexSkrypnyk AlexSkrypnyk marked this pull request as draft May 29, 2024 10:06
@AlexSkrypnyk AlexSkrypnyk self-assigned this May 29, 2024
@AlexSkrypnyk AlexSkrypnyk added D10 PR: DO NOT MERGE Do not merge this pull request PR: Do not review Do not review this pull request labels May 29, 2024
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/10x-add-status-ci branch from 0edc314 to 78fb0cd Compare May 29, 2024 10:43
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/10x-add-status-ci branch from 9153406 to c68f84b Compare May 29, 2024 12:11
@AlexSkrypnyk AlexSkrypnyk marked this pull request as ready for review May 29, 2024 13:04
@AlexSkrypnyk AlexSkrypnyk requested review from normanlolx and webflo May 29, 2024 13:04
@AlexSkrypnyk AlexSkrypnyk added PR: Needs review Pull request needs a review from assigned developers and removed PR: DO NOT MERGE Do not merge this pull request PR: Do not review Do not review this pull request labels May 29, 2024
Copy link
Collaborator

@normanlolx normanlolx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out, LGTM 👏🏻

@AlexSkrypnyk AlexSkrypnyk merged commit 201e219 into 10.x May 29, 2024
@AlexSkrypnyk AlexSkrypnyk deleted the feature/10x-add-status-ci branch May 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D10 PR: Needs review Pull request needs a review from assigned developers

3 participants