Add return code to DrupalParanoiaCommand #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This is just an improvement since every command should have a return code.
I've run into a problem while using Drupal Paranoia and Composer 2 with PlatformSh.
Composer 2 has been dowloaded and installed using Composer 1. This led to dependencies not having the correct version usually defined by
composer.lock. I ended up withsymfony/console:5.3.10, and it'sCommand::execute()signature does not match the one inDrupalParanoiaCommand::execute().I have solved the issue with PlatformSh, but I think having a return code is more consistent any other UNIX command, and also a return code 0 is equivalent to what it's done right now.