Remove the pin for urllib3 #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #507 +/- ## ========================================== - Coverage 64.26% 63.70% -0.56% ========================================== Files 31 31 Lines 53579 53579 Branches 3905 3905 ========================================== - Hits 34430 34133 -297 - Misses 18989 19412 +423 + Partials 160 34 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxbelanger changed the title urllib3This reverts commit 64f857d.
maxbelanger changed the title urllib3 maxbelanger changed the title urllib3urllib3 
greg-db approved these changes Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now that CI works again and with the added tests, we can verify that certificate pinning does work with
urllib3==2.Fixes #506.