Stop providing a hardcoded CA bundle #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
maxbelanger changed the title maxbelanger changed the title 
maxbelanger commented May 7, 2024
sderickson approved these changes May 8, 2024
maxbelanger force-pushed the remove-pinning branch from ff3a81b to 3e39f8e Compare 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #489 +/- ## ======================================= Coverage 64.26% 64.26% ======================================= Files 31 31 Lines 52609 52606 -3 Branches 3841 3841 ======================================= + Hits 33807 33808 +1 + Misses 18641 18638 -3 + Partials 161 160 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxbelanger changed the title 
april approved these changes May 9, 2024
| # TODO: backend is no longer returning `BadInputError` | ||
| # with pytest.raises(BadInputError,) as cm: | ||
| # malformed_token_dbx.files_list_folder('') | ||
| # assert 'token is malformed' in cm.value.message |
There was a problem hiding this comment.
Can we remove these comments, or is the intention to fix this?
There was a problem hiding this comment.
The intention is to fix this in a future PR. This is also not technically introduced in this PR, I've just moved this test out of the class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The SDK no longer provides a CA bundle to verify SSL connections. This also allows us to remove the runtime dependency on
pkg_resourcesand thussetuptools.The
ca_certsparameter is still supported, so users can pin with their own CA bundle if they so choose. Otherwise, the default verification mechanism in therequestslibrary now applies (this usescertifiand/or system certificates, depending on the configuration).Improves integration tests to cover both scenarios (i.e. when a bundle is provided, and when one isn't).
Checklist
General Contributing
Is This a Code Change?
Validation
toxpass?