Skip to content

Add support for java services in affectedModuleDetector plugin #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinder-ravitejabonagiri wants to merge 1 commit into from
Closed

Add support for java services in affectedModuleDetector plugin #71

tinder-ravitejabonagiri wants to merge 1 commit into from

Conversation

@tinder-ravitejabonagiri
Copy link

@tinder-ravitejabonagiri tinder-ravitejabonagiri commented Aug 31, 2021

Addressing the issue in #70
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

ravitejabonagiri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
chris-mitchell
chris-mitchell reviewed Aug 31, 2021
View reviewed changes
...edetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt
rootProject.subprojects { project ->
project.afterEvaluate {
val pluginIds = setOf("com.android.application", "com.android.library", "java-library", "kotlin")
val pluginIds = setOf("com.android.application", "com.android.library", "java", "kotlin")
Copy link
Contributor

@chris-mitchell chris-mitchell Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Is there a reason we removed java-library from the setOf? Shouldn't we include both java-library and java ?
Copy link
Author

@tinder-ravitejabonagiri tinder-ravitejabonagiri Aug 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java-library plugin applies java plugin.
https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaLibraryPlugin.java#L51

So, all java libraries do contain java plugin.
Copy link
Contributor

@chris-mitchell chris-mitchell Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. Once the CLA is signed, we can merge this.
@joshafeinberg
Copy link
Member

joshafeinberg commented Apr 13, 2022

Closing this PR as the CLA has not been signed. This will be resolved in #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@tinder-ravitejabonagiri @CLAassistant @joshafeinberg @chris-mitchell