Add maven and gradle plugins for publishing #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
chris-mitchell commented Oct 28, 2020
chris-mitchell commented - Adds gradle portal plugin
- Adds maven publishing plugin
- Refactors samples so we can publish locally and consume snapshots
- Add releasing notes
digitalbuddha approved these changes Oct 29, 2020
affectedmoduledetector/build.gradle Outdated
| implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" | ||
| testImplementation("junit:junit:4.13.1") | ||
| testImplementation("com.nhaarman:mockito-kotlin:1.5.0") | ||
| testImplementation("org.jetbrains.kotlin:kotlin-test-junit:1.4.10") |
Contributor
There was a problem hiding this comment.
Nit kotlin test is just an extra dep to maintain
Contributor Author
There was a problem hiding this comment.
Good catch, removed.
| @@ -0,0 +1 @@ | |||
| implementation-class=com.dropbox.affectedmoduledetector.AffectedModuleDetectorPlugin No newline at end of file | |||
Contributor
There was a problem hiding this comment.
This is a recent thing that came out https://github.com/ansman/auto-plugin
Contributor Author
There was a problem hiding this comment.
That seems great - I tried to integrate but ran into a couple issues.
sample/build.gradle Outdated
| "buildSrc/" | ||
| ] | ||
| apply plugin: "org.jlleitschuh.gradle.ktlint" | ||
| //apply plugin: "com.dropbox.affectedmoduledetector.AffectedModuleDetector" |
Contributor Author
There was a problem hiding this comment.
At the moment, yes. The plugin is under review on the portal plugin, so this won't work unless someone publishes locally.
I'll add back in once we have a snapshot live.
Contributor Author
There was a problem hiding this comment.
Actually, I just received an email saying it is published. Woo! I'll add this back in.
sample/sample-app/build.gradle Outdated
| jvmTarget = '1.8' | ||
| } | ||
| | ||
| // affectedModuleDetector { |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.