Skip to content

Conversation

@jonnycaley
Copy link
Contributor

Fixes #47

If you make an uncommitted change and run the command:

git --no-pager diff --name-only HEAD..$sha 

the uncommitted changes wont be displayed.

If you run the command:

git --no-pager diff --name-only $sha 

the uncommitted changes will be shown.

This is because HEAD points to the last commit on the branch, therefore not considering any uncommitted changes made after that point.

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #48 (518da3a) into main (5fc7d50) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #48 +/- ## ========================================= Coverage 46.15% 46.15% Complexity 39 39 ========================================= Files 11 11 Lines 429 429 Branches 95 95 ========================================= Hits 198 198 Misses 200 200 Partials 31 31 
Impacted Files Coverage Δ Complexity Δ
...in/com/dropbox/affectedmoduledetector/GitClient.kt 10.29% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc7d50...518da3a. Read the comment docs.

@digitalbuddha digitalbuddha merged commit 3023ee6 into dropbox:main Dec 23, 2020
@digitalbuddha
Copy link
Contributor

Thanks!

@jonnycaley
Copy link
Contributor Author

No worries. Can you keep me updated on when a new version is released with these changes in?

@jonnycaley
Copy link
Contributor Author

Sorry to bug you again @digitalbuddha. Are you able to release a new version to maven whenever you have some time so I can try it for a personal project?

@chris-mitchell
Copy link
Contributor

Hey @jonnycaley - I think we have another bug to resolve before we roll out another version. If you'd like, you can use the 0.1.1-SNAPSHOT release which should have your changes available.

@jonnycaley
Copy link
Contributor Author

jonnycaley commented Jan 7, 2021

Hey @chris-mitchell, thanks for the update. Could that bug have anything to do with the output that I am getting?

[INFO] [amd] Modules provided: null [INFO] [amd] Using real detector with ALL_AFFECTED_PROJECTS 
@digitalbuddha
Copy link
Contributor

Maybe? do you mind trying the latest snapshot. If not we can get your logs and fix whatever issue you have

@jonnycaley
Copy link
Contributor Author

Yep, latest PR has fixed it. Thanks 😄

@digitalbuddha
Copy link
Contributor

Great! Expect a release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants