Ensure calls to configure are run after all projects have been configured #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| closes #42 |
digitalbuddha approved these changes Dec 10, 2020
Codecov Report
@@ Coverage Diff @@ ## main #43 +/- ## ============================================ + Coverage 39.04% 41.64% +2.60% - Complexity 25 29 +4 ============================================ Files 8 8 Lines 397 401 +4 Branches 87 89 +2 ============================================ + Hits 155 167 +12 + Misses 211 203 -8 Partials 31 31
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The module detector was being configured mid-way through the project graph evaluation. This caused some project relations to not be identified and projects to be missed.
This pushes the plugins call until after the projects have been evaluated, and implements a check to ensure everything has been evaluated before proceeding.