Refactor affected test config #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## main #41 +/- ## ============================================= + Coverage 39.04% 51.00% +11.96% - Complexity 25 34 +9 ============================================= Files 8 8 Lines 397 398 +1 Branches 87 86 -1 ============================================= + Hits 155 203 +48 + Misses 211 168 -43 + Partials 31 27 -4
Continue to review full report at Codecov.
|
Contributor
| 12% coverage increase. Fancy! Will review in am |
chris-mitchell commented Dec 10, 2020
| val assembleAndroidTestTask get() = "assemble${variantToTest?.capitalize()}AndroidTest" | ||
| val runAndroidTestTask get() = "connected${variantToTest?.capitalize()}AndroidTest" | ||
| val jvmTest get() = "test${variantToTest?.capitalize()}UnitTest" | ||
| var assembleAndroidTestTask : String? = "assembleDebugAndroidTest" |
Contributor Author
There was a problem hiding this comment.
Opening these up to be nullable. If they are set to null, we'll ignore that module when creating the main task.
| val paths = getAffectedPaths(testType, project) | ||
| paths.forEach { path -> | ||
| task.dependsOn(path) | ||
| val pluginIds = listOf("com.android.application", "com.android.library", "java-library") |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates the way we define our extension so that consumers can simply define the entire name of the task to run for jvm / assemble android test / run android test. See the sample app for examples.