Miken/affected tasks plugin #19
Conversation
There was a problem hiding this comment.
Was challenging for me to follow how this fits together because the levels of abstraction used are pretty low (aka close to gradle) and my knowledge level in this particular area is only high (we want to allow folks to control which test tasks get called on modules when they call runAffectedUnitTests). Maybe we can bridge that gap to increase clarity. So, take my comments with that background.
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
chris-mitchell left a comment
chris-mitchell left a comment There was a problem hiding this comment.
Thanks for putting this together! Let me know if you have any questions, happy to help.
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
| | ||
| dependencies { | ||
| implementation("com.dropbox.affectedmoduledetector:affectedmoduledetector:0.1.0-SNAPSHOT") | ||
| implementation("com.dropbox.affectedmoduledetector:affectedmoduledetector:0.1.0") |
There was a problem hiding this comment.
This was intentionally set to -SNAPSHOT so that developers could test their changes by pushing to their local maven repo.
I probably also need to update the release notes to ensure this value is bumped, otherwise the sample will use an out of date version of the library.
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt Outdated Show resolved Hide resolved
| registerAffectedConnectedTestTask(rootProject) | ||
| } | ||
| | ||
| filterAndroidTests(project) |
There was a problem hiding this comment.
I am not sure if these two methods are necessary for other folks or if they are just unique issues in our environment. We may want to remove them to avoid confusion.
There was a problem hiding this comment.
I think it makes sense since it is keyed off them enabling the detector.
| ran checks locally |
Adds an affected tasks plugin to the sample. Will propogate to plugin portal eventually