Skip to content

Make ToStringLogger config cacheable #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshafeinberg merged 2 commits into from
Jul 15, 2022
Merged

Make ToStringLogger config cacheable #151

joshafeinberg merged 2 commits into from
Jul 15, 2022

Conversation

@joshafeinberg
Copy link
Member

@joshafeinberg joshafeinberg commented Jul 7, 2022

addBuildListener is not cacheable so we needed to switch to using a Build Service to be notified when builds are finished. We know the build is finished when close on the BuildService is called so we can migrate to writing out to the file there. This required a bit of a rewrite of the ToStringLogger to accept a provider so it can properly get that param from the BuildService
@codecov
Copy link

codecov bot commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #151 (47e75fa) into main (6c2b902) will decrease coverage by 3.32%.
The diff coverage is 9.52%.

❗ Current head 47e75fa differs from pull request most recent head 3770503. Consider uploading reports for the commit 3770503 to get more accurate results

@@ Coverage Diff @@ ## main #151 +/- ## ============================================ - Coverage 53.69% 50.37% -3.33%  + Complexity 68 66 -2  ============================================ Files 13 13 Lines 514 532 +18 Branches 97 99 +2 ============================================ - Hits 276 268 -8  - Misses 212 237 +25  - Partials 26 27 +1
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 42.04% <0.00%> (+1.38%) ⬆️
...m/dropbox/affectedmoduledetector/ToStringLogger.kt 0.00% <0.00%> (-64.71%) ⬇️
...ctedmoduledetector/AffectedModuleDetectorPlugin.kt 51.00% <36.36%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6897aa6...3770503. Read the comment docs.
@joshafeinberg joshafeinberg merged commit c18ef5d into main Jul 15, 2022
@joshafeinberg joshafeinberg deleted the jfein/fix-config-cache-issues branch July 15, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@joshafeinberg @chris-mitchell @Evleaps