Skip to content

Conversation

@joshafeinberg
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #116 (774a036) into main (897934e) will not change coverage.
The diff coverage is n/a.

❗ Current head 774a036 differs from pull request most recent head 00915a6. Consider uploading reports for the commit 00915a6 to get more accurate results

Impacted file tree graph

@@ Coverage Diff @@ ## main #116 +/- ## ========================================= Coverage 50.55% 50.55% Complexity 59 59 ========================================= Files 12 12 Lines 451 451 Branches 91 91 ========================================= Hits 228 228 Misses 196 196 Partials 27 27 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897934e...00915a6. Read the comment docs.

*/
plugins {
kotlin("jvm") version "1.4.10"
kotlin("jvm") version "1.6.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse the constants from Dependencies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear so. I think since that file is defined inside the buildSrc project we can't use it in the build.gradle for buildSrc

run: |
./gradlew :affectedmoduledetector:publishToMavenLocal
cd sample
./gradlew build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we used to have this in Travis, but seems like we lost it.

@joshafeinberg joshafeinberg merged commit 33a6511 into main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants