Skip to content

fix bigint library wrong behavior #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragonslayerx merged 2 commits into from
Dec 23, 2019
Merged

fix bigint library wrong behavior #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf503d
bigint: fix: toString with value 0
WildfootW Dec 22, 2019
d6157a8
bigint: fix: relational operators behaviors
WildfootW Dec 22, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bigint: fix: relational operators behaviors
  • Loading branch information
@WildfootW
WildfootW committed Dec 22, 2019
commit d6157a8996aaf4bfb90e4964a24a7ba444d3bce2
9 changes: 5 additions & 4 deletions src/bigint_library.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class Bigint {
return size;
}

//Logical Operations
// Relational Operations
bool equals(char *X, int lenX, char *Y, int lenY) {
int maxLen = max(lenX, lenY);
align(X, maxLen); align(Y, maxLen);
Expand All @@ -115,8 +115,9 @@ class Bigint {
bool greater(char *X, int lenX, char *Y, int lenY) {
int maxLen = max(lenX, lenY);
align(X, maxLen); align(Y, maxLen);
for (int i = maxLen; i >= 0; i--) {
for (int i = maxLen - 1; i >= 0; i--) {
if (X[i] > Y[i]) return true;
if (X[i] < Y[i]) return false;
}

//Put everything back to original state
Expand Down Expand Up @@ -181,13 +182,13 @@ class Bigint {
return modulo;
}

//Logical Operators
// Relational Operators
bool operator ==(Bigint &b) {
return equals(this->x, this->length, b.x, b.length);
}

bool operator >(Bigint &b) {
return !greater(b.x, b.length, this->x, this->length);
return greater(this->x, this->length, b.x, b.length);
}

bool operator >=(Bigint &b) {
Expand Down