Skip to content

Delay converting to seconds #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Delay converting to seconds #1825

merged 1 commit into from
May 30, 2019

Conversation

@jeffwidman
Copy link
Contributor

@jeffwidman jeffwidman commented May 30, 2019 •
edited by dpkp
Loading

Delaying the conversion to seconds makes the code intent more clear.

Originally discussed in #1823 (comment).

This change is Reviewable
@jeffwidman
Delay converting to seconds
ad41533 
Delaying the conversion to seconds makes the code intent more clear.
@jeffwidman jeffwidman mentioned this pull request May 30, 2019
Merged
@jeffwidman jeffwidman merged commit 79dd508 into master May 30, 2019
@jeffwidman jeffwidman deleted the delay-units-conversion-til-last-possiblepoint branch May 30, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jeffwidman